Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped the ): from getting absorbed into the link #507

Merged
merged 1 commit into from Jan 21, 2020

Conversation

mitchellroe
Copy link
Contributor

Summary

This change delimits a link with less-than, greater-than symbols "< >" to avoid surrounding text from being absorbed into it. In my tests,

3. Install Go (modify installation to latest Go version from https://golang.org/dl/):

effectively had a link at the end pointing to https://golang.org/dl/): instead of the intended https://golang.org/dl/.

Ticket Link

None. Minor fix.

Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- thanks, @mitchellroe!

@lieut-data lieut-data added the 1: Dev Review Requires review by a core commiter label Jan 19, 2020
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Jan 21, 2020
@hanzei hanzei merged commit 5ee62c6 into mattermost:master Jan 21, 2020
@mitchellroe mitchellroe deleted the ubuntu-link-delimiter branch February 22, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants