Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guidelines #61

Merged
merged 2 commits into from
Dec 18, 2017
Merged

Update contribution guidelines #61

merged 2 commits into from
Dec 18, 2017

Conversation

jwilander
Copy link
Member

Also removed empty page + minor update to paragraph spacing.

Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall it's moving in the right direction.

I'm just wondering if we should separate the flow in some way, rather than try to combine them all.

E.g. if one is interested in Redux, then join these channels, pick a help wanted ticket here, set up your machine, etc.

@jwilander
Copy link
Member Author

Yeah I was thinking about that as well, but I do think there is a good chunk that would be shared between all of them

We can probably re-org the whole thing a bit to make it work with having some info here and specific info in the other sections

@jasonblais
Copy link
Contributor

We can probably re-org the whole thing a bit to make it work with having some info here and specific info in the other sections

Should I create a separate ticket for it?

@jwilander
Copy link
Member Author

@jasonblais yes please, that way this PR won't go stale and we can merge it

@jasonblais
Copy link
Contributor

Thanks, I meant to come back to this and review.

Made a couple of minor tweaks 00d1617

@jwilander jwilander merged commit 0b696dd into master Dec 18, 2017
@jwilander jwilander deleted the contribute branch December 18, 2017 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants