Skip to content
This repository has been archived by the owner on May 20, 2022. It is now read-only.

Fixing web proxy dealing with protocols #58

Merged
merged 2 commits into from
Nov 22, 2016
Merged

Fixing web proxy dealing with protocols #58

merged 2 commits into from
Nov 22, 2016

Conversation

jdoubleu
Copy link
Contributor

@jdoubleu jdoubleu commented Oct 15, 2016

See #57 and mattermost/mattermost#3944

Added workarounds to both nginx configs (ssl and no ssl) to grab the correct protocol and pass it in the X-Forwared-Proto header.

If this web proxy receives a connection which already has X-Forwared-Proto set it will use this, otherwise it will sue default $scheme variable.

@monty241
Copy link

@jdoubleu Hi John, would it be helpful when I would change our generated nginx configuration by hand with the changes in the files and checked whether it solves our mattermost/GitLab integration issues?
After that I can re-generate them so no lasting harm done in our production environment.

@jdoubleu
Copy link
Contributor Author

I can confirm this works.

Tested it in my environment (described here: mattermost/mattermost#3944 (comment)) using the new nginx config file.

@eungjun-yi
Copy link
Contributor

Thanks @jdoubleu for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community!

@eungjun-yi
Copy link
Contributor

Sorry for late response!

@eungjun-yi
Copy link
Contributor

@jdoubleu Could you please help the complete the license agreement?

@jdoubleu
Copy link
Contributor Author

@npcode sorry for the delay. Didn't get notified about changes here, for some reason.

I filled out the license agreement.
Is there anything else I have to consider? E.g. changing the title to the Jira Ticket ID?

@eungjun-yi
Copy link
Contributor

@jdoubleu That's all. Thanks!

@eungjun-yi eungjun-yi merged commit 77163a6 into mattermost:master Nov 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants