Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Linux, ps -e used in make stop task produces only the process name… #1370

Merged
merged 1 commit into from Jan 24, 2018
Merged

In Linux, ps -e used in make stop task produces only the process name… #1370

merged 1 commit into from Jan 24, 2018

Conversation

phuihock
Copy link

@phuihock phuihock commented Jan 22, 2018 •
edited by enahum

… without the argument. Should use ps -ef.

Summary

In Linux, ps -e used in make stop task produces only the process name without the argument. Should use ps -ef.

Ticket Link

Resolves #1359

Checklist

N/A

Device Information

N/A

Screenshots

N/A

@mattermod
Copy link
Contributor

Thanks @phuihock for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@enahum enahum requested a review from hmhealey January 23, 2018 13:12
@enahum enahum added the 2: Dev Review Requires review by a core commiter label Jan 23, 2018
enahum
enahum approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @phuihock

@hmhealey
Copy link
Member

Looks like we've all been outed as Mac users. Thanks for fixing that

@hmhealey hmhealey merged commit dd180fd into mattermost:master Jan 24, 2018
@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Jan 24, 2018
@phuihock phuihock deleted the 1359-cannot-make-stop branch January 25, 2018 04:15
dbrgn pushed a commit to coredump-ch/mattermost-mobile that referenced this pull request Mar 2, 2018
@phuihock @dbrgn
In Linux, ps -e used in make stop task produces only the process name…
62aecb1 
… without the argument. Should use ps -ef. (mattermost#1370)
@uusijani uusijani mentioned this pull request Jul 12, 2018
Merged
@lindy65 lindy65 added the Tests/Not Needed Does not require tests label Apr 14, 2019
@kumarrahul-rkv
Copy link

On my side still not working. When I ran make build-android command.

image

@enahum
Copy link
Contributor

enahum commented Sep 27, 2019

@kumarrahul-rkv you are using a very old version of npm please upgrade and try again.

In the docs you’ll find the recommended version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@enahum enahum enahum approved these changes

Assignees
No one assigned
Labels
Tests/Not Needed Does not require tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot 'make stop'
6 participants
@phuihock @mattermod @hmhealey @kumarrahul-rkv @enahum @lindy65