Set Roboto as the default font family for Android #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
reviewed
Oct 10, 2018
| this.getStartupThemes(); | ||
| this.getAppCredentials(); | ||
| } | ||
|
|
||
| setFontFamily = () => { | ||
| // Set a global font for Android | ||
| if (Platform.OS === 'android') { |
There was a problem hiding this comment.
Is it possible to do this from Android's styles.xml?
https://stackoverflow.com/questions/16404820/how-to-set-default-font-family-for-entire-android-app
There was a problem hiding this comment.
I was following this https://medium.com/react-native-training/react-native-custom-fonts-ccc9aacf9e5e and somehow it gives me more confidence that is going to use the right font
hmhealey
reviewed
Oct 10, 2018
hmhealey
approved these changes
Oct 10, 2018
sudheerDev
approved these changes
Oct 11, 2018
sudheerDev
added
4: Reviews Complete
enahum
added a commit
that referenced
this pull request
Oct 13, 2018
lindalumitchell
added
Build Apps for PR
|
@sudheerDev How can I use this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some Android devices (OnePlus and Oppo) the text is sometimes being cut-off and according to facebook/react-native#15114 switching the default font to use Roboto fixes the issue
This is a great candidate to build the PR and have the reporter download the apk and test it.
Fixes: #2009
Ticket Link
https://mattermost.atlassian.net/browse/MM-11845
Device Information
This PR was tested on: Android Pie, Oreo and Nougat