MM-17044 Load posts until no more are needed #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
2: Dev Review
saturninoabril
requested changes
Dec 3, 2019
migbot
approved these changes
Dec 3, 2019
|
@enahum can you clarify if this is for 1.26 or 1.27? The linked ticket says 1.27 but I'm confused by the |
|
@DHaussermann the mobile branching is exactly the same as the rest. Basically this will be cherry picked for 1.27 once the branch is created. |
amyblais
removed
the
CherryPick/Approved
|
/update-branch |
DHaussermann
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
Tested and passed
- Issue is resolved. The app will fetch all join/leave posts
- Exploratory testing did not find any cases of missing posts
- Performed tests where some posts where made and deleted while the user was not logged in. All correct posts are shown.
LGTM!
DHaussermann
added
4: Reviews Complete
|
@migbot sorry, I missed that Amy added the |
|
@DHaussermann Shouldn't be a problem as v1.28 will be cut from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the post list updates and there are more posts to load and the screen has not been filled yet we will continue on loading posts until one of the conditions are met, this helps avoiding a continuous loading indicator when there are too many combined system messages in a channel.
Ticket Link
https://mattermost.atlassian.net/browse/MM-17044