Properly unset the active channel in the server #7919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
added
2: Dev Review
harshilsharma63
approved these changes
Apr 24, 2024
hmhealey
approved these changes
Apr 24, 2024
|
Is this PR still waiting for QA? |
|
@enahum Yes. @yasserfaraazkhan friendly reminder. |
yasserfaraazkhan
approved these changes
May 5, 2024
larkox
added
4: Reviews Complete
cyrusjc
pushed a commit
to cyrusjc/mattermost-mobile
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we mark a channel as read on the server, the "active channel" gets set. This handles how we receive push notifications.
This PR makes sure we unset the active channel when we exit from the channel screen, or we send the app to the background.
I also piggybacked a fix for channels in other servers being read when they should not.
Ticket Link
Fix https://mattermost.atlassian.net/browse/MM-57000
Release Note