Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reporting variables in the community report #7997

Merged
merged 34 commits into from
Jun 26, 2024
Merged

fix reporting variables in the community report #7997

merged 34 commits into from
Jun 26, 2024

Conversation

yasserfaraazkhan
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan commented Jun 7, 2024 •
edited
Loading

Summary

Before 👇
Screenshot 2024-06-08 033158

After ☝️

Ticket Link

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added kind/bug Categorizes issue or PR as related to a bug. release-note labels Jun 7, 2024
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 7, 2024
@mm-cloud-bot mm-cloud-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 7, 2024
@yasserfaraazkhan yasserfaraazkhan removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 7, 2024
@yasserfaraazkhan yasserfaraazkhan changed the base branch from feat/introduce-cmt-testing to main June 7, 2024 16:13
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 7, 2024
@mm-cloud-bot mm-cloud-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 7, 2024
@yasserfaraazkhan yasserfaraazkhan removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 7, 2024
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 7, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 7, 2024
@yasserfaraazkhan yasserfaraazkhan changed the base branch from main to feat/introduce-cmt-testing June 7, 2024 22:00
toninis added a commit that referenced this pull request Jun 10, 2024
@toninis
fix: Incorporate changes from #7997
e92c1b7
@toninis
Copy link
Contributor

toninis commented Jun 10, 2024

Fixed in favor of e92c1b7

Base automatically changed from feat/introduce-cmt-testing to main June 10, 2024 11:06
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 10, 2024
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Jun 20, 2024
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Jun 20, 2024
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 20, 2024
@yasserfaraazkhan
Copy link
Contributor Author

/update-branch

@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Jun 21, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 21, 2024
@yasserfaraazkhan yasserfaraazkhan marked this pull request as ready for review June 21, 2024 10:55
toninis
toninis requested changes Jun 26, 2024
View reviewed changes
.github/workflows/e2e-detox-template.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-detox-template.yml Outdated
Comment on lines 64 to 65
BRANCH: ${{ github.head_ref || github.ref_name }}
COMMIT_HASH: ${{ github.sha }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add those . It's best to calculate them during the run to ensure we have the proper values per scenario (scheduled, external trigger , fork ..)

.github/workflows/e2e-detox-template.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-detox-template.yml Outdated Show resolved Hide resolved
@toninis
Copy link
Contributor

toninis commented Jun 26, 2024

Overall great work 🚀
Some minor improvements for the pipelines

@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 26, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 26, 2024
@yasserfaraazkhan yasserfaraazkhan merged commit 351c877 into main Jun 26, 2024
23 checks passed
@yasserfaraazkhan yasserfaraazkhan deleted the fix/cmt-report branch June 26, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saturninoabril saturninoabril saturninoabril approved these changes

@toninis toninis toninis approved these changes

@mvitale1989 mvitale1989 Awaiting requested review from mvitale1989

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yasserfaraazkhan @toninis @saturninoabril @mm-cloud-bot @mattermost-build