Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run db migration instead of version command #350

Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix: run db migration instead of version command #350

merged 1 commit into from
Apr 26, 2023

Conversation

fmartingr
Copy link
Contributor

@fmartingr fmartingr commented Apr 26, 2023 •
edited
Loading

Summary

This fixes the removal of the store initialialization for the version command of the mattermost server under
mattermost/mattermost#19364

Ticket Link

None

Release Note

fix: use `mattermost db migration` for database migrations instead of `mattermost version`

Remember to add a "Breaking change" notice that the operator won't work for version < 6.5.0.

@fmartingr fmartingr added the 2: Dev Review Requires review by a developer label Apr 26, 2023
@fmartingr fmartingr self-assigned this Apr 26, 2023
@mm-cloud-bot mm-cloud-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 26, 2023
@fmartingr
fix: run db migration instead of version command
9c0fda8 
This fixes the removal of the store initialialization for the
version command of the mattermost server under
mattermost/mattermost#19364
@stafot stafot self-requested a review April 26, 2023 14:06
gabrieljackson
gabrieljackson approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great working finding this!

@fmartingr fmartingr merged commit eb6d053 into master Apr 26, 2023
4 checks passed
@fmartingr fmartingr deleted the fix/db-migration branch April 26, 2023 14:58
fmartingr added a commit that referenced this pull request Apr 26, 2023
@fmartingr
fix: run db migration instead of version command (#350)
3c7c810 
This fixes the removal of the store initialialization for the
version command of the mattermost server under
mattermost/mattermost#19364
@fmartingr fmartingr added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Apr 26, 2023
@lieut-data lieut-data mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stafot stafot stafot approved these changes

@gabrieljackson gabrieljackson gabrieljackson approved these changes

@stylianosrigas stylianosrigas stylianosrigas approved these changes

@lieut-data lieut-data Awaiting requested review from lieut-data

Assignees

@fmartingr fmartingr

Labels
3: Reviews Complete All reviewers have approved the pull request kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fmartingr @stafot @gabrieljackson @stylianosrigas @mm-cloud-bot