-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go to version 1.21 #363
Conversation
ba575a1
to
4aca425
Compare
with: | ||
fetch-depth: 0 | ||
path: src/github.com/mattermost/mattermost-operator | ||
|
||
- name: ci/setup-go | ||
uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # v3.5.0 | ||
with: | ||
go-version: "1.19" | ||
go-version: "1.21" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go-version: "1.21" | |
go-version-file: go.mod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fancy! I have a few follow-up CI PRs in the queue so I will add this alongside those. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It would be nice if we could leverage the Makefile
GOLANG_VERSION
variable into other places where is needed, to avoid having to find&replace every once in a while.
Fixes https://mattermost.atlassian.net/browse/CLD-6261