Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go to version 1.21 #363

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Bump Go to version 1.21 #363

merged 1 commit into from
Sep 5, 2023

Conversation

gabrieljackson
Copy link
Collaborator

@gabrieljackson gabrieljackson commented Sep 5, 2023

Fixes https://mattermost.atlassian.net/browse/CLD-6261

Bump Go to version 1.21

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 5, 2023
with:
fetch-depth: 0
path: src/github.com/mattermost/mattermost-operator

- name: ci/setup-go
uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # v3.5.0
with:
go-version: "1.19"
go-version: "1.21"
Copy link
Contributor

@fmartingr fmartingr Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Suggested change
go-version: "1.21"
go-version-file: go.mod

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy! I have a few follow-up CI PRs in the queue so I will add this alongside those. Thanks!

@gabrieljackson gabrieljackson added the 2: Dev Review Requires review by a developer label Sep 5, 2023
@gabrieljackson gabrieljackson marked this pull request as ready for review September 5, 2023 14:38
Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It would be nice if we could leverage the Makefile GOLANG_VERSION variable into other places where is needed, to avoid having to find&replace every once in a while.

@fmartingr fmartingr added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Sep 5, 2023
@gabrieljackson gabrieljackson merged commit 2ba37bd into master Sep 5, 2023
5 checks passed
@gabrieljackson gabrieljackson deleted the go-1.21 branch September 5, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants