Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go modules for coverage CI job #26

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Use Go modules for coverage CI job #26

merged 1 commit into from
Aug 30, 2019

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Aug 22, 2019 •
edited
Loading

Completely removes server/.depensure dependencies from Makefile

Complement of #5

@tnir
Use Go modules for coverage CI job
bb0f196 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir force-pushed the go-modules-for-coverage-job branch from 45dcd7a to bb0f196 Compare August 22, 2019 07:42
@tnir
Copy link
Contributor Author

tnir commented Aug 22, 2019

CircleCI Pipeline for the PR: https://circleci.com/workflow-run/0f154711-b707-4eb8-a7b5-7fa19ed483cf

@hanzei hanzei requested review from cpanato and cpoile August 22, 2019 12:18
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Aug 22, 2019
cpoile
cpoile approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @tnir ! Make sure to fill out the contributor agreement. :)

@cpanato
Copy link
Contributor

cpanato commented Aug 26, 2019

/check-cla

@cpanato
Copy link
Contributor

cpanato commented Aug 26, 2019

why this not run on circleci?
@tnir can you push an empty commit to see if it will trigger circleci?

@tnir
Copy link
Contributor Author

tnir commented Aug 27, 2019

@cpanato Umm, you could see coverage job named as plugin-ci/coverage at https://circleci.com/gh/tnir/mattermost-plugin-aws-SNS/12 as part of #26 (comment) . Or do you mean you want to see it at the original https://circleci.com/gh/mattermost/mattermost-plugin-aws-SNS ?

@cpanato cpanato added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 30, 2019
@cpanato cpanato merged commit c4420d2 into mattermost-community:master Aug 30, 2019
@tnir tnir deleted the go-modules-for-coverage-job branch August 30, 2019 13:53
@tnir
Copy link
Contributor Author

tnir commented Aug 30, 2019

@cpanato Thanks. We would see the coverage reports at https://codecov.io/gh/mattermost/mattermost-plugin-aws-SNS when they are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpoile cpoile cpoile approved these changes

@cpanato cpanato cpanato approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tnir @cpanato @cpoile @hanzei