Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to route for non-existent plugin #54

Closed
dalenewman opened this issue Apr 29, 2022 · 12 comments
Closed

Access to route for non-existent plugin #54

dalenewman opened this issue Apr 29, 2022 · 12 comments
Labels
bug Something isn't working

Comments

@dalenewman
Copy link

I'm getting tons of these errors on my 6.4.2 mattermost, how do I make it stop?

{
    "timestamp": "2022-04-15 16:56:39.235 Z",
    "level": "error",
    "msg": "Access to route for non-existent plugin",
    "caller": "app/plugin_requests.go:37",
    "missing_plugin_id": "com.mattermost.calls",
    "url": "/plugins/com.mattermost.calls/channels",
    "error": "plugin not found: com.mattermost.calls"
}
@streamer45
Copy link
Contributor

Hi @dalenewman ,

is the plugin enabled and running? Those errors would suggest it's not but clients are still making requests to it.

@streamer45 streamer45 self-assigned this Apr 30, 2022
@dalenewman
Copy link
Author

dalenewman commented Apr 30, 2022 via email

@streamer45
Copy link
Contributor

No it’s not enabled. There’s nothing about it in the config.json or the system console (ui). Is there perhaps something I can put in the server’s config to get the clients to stop making requests for it? For example, I could install it but explicitly disable it? Thanks.

I see. While the error may be annoying it's also totally harmless. I think we need to figure out why the requests are happening with the plugin not even installed. To make them go away now you could install and enable the plugin but explicitly disable allowing calls so essentially it will make it unusable for users:

image

Not sure it's worth it as the error is really just a log, nothing serious is happening.

@cpoile I am wondering if it's the mobile app that could be causing this?

@dalenewman
Copy link
Author

dalenewman commented Apr 30, 2022 via email

@streamer45
Copy link
Contributor

Sure, that's fair enough. We'll also be looking into fixing this on the client side.

@streamer45
Copy link
Contributor

streamer45 commented May 2, 2022

Created MM-43904 to track this internally.

@streamer45 streamer45 added the bug Something isn't working label May 2, 2022
@streamer45 streamer45 assigned cpoile and unassigned streamer45 May 2, 2022
@cpoile
Copy link
Member

cpoile commented May 2, 2022

Hi @dalenewman , I'm looking into this now. I've found where the problem is, and we'll discuss the solutions and get back to you with some options. Thanks!

@dalenewman
Copy link
Author

dalenewman commented May 4, 2022

Thanks @cpoile.

FWIW, here's my actions so far...

I've added the configuration for the calls plugin to config.json with it is explicitly disabled. In addition, I've added the plugin files (the plugin itself and the signature) to the /opt/mattermost/prepackaged_plugins folder. For some reason it doesn't automatically install (and I can't see any logs stating the reason why).

I was able to manually upload the plugin to my development environment and see the UI. However, when I tried this in my integration testing environment, it crashed the Mattermost service. So, I have opted not to try and upload it in the production environment.

I am monitoring the logs to see if I get more errors. I've directed the users to upgrade their clients just in case they're using an old client that's some how "remembering" the calls plugin from an earlier implementation.

Looking forward to hearing the options, because obviously (based on the above) I'm just using a trial and error strategy.

@streamer45
Copy link
Contributor

Hi @dalenewman , the plugin should definitely not cause a crash. If it does please feel free to send some server logs our way (e.g. stacktrace) so we can have a look.

I've directed the users to upgrade their clients just in case they're using an old client that's some how "remembering" the calls plugin from an earlier implementation.

Actually that may make things worse as it was a recent addition to the mobile app that's causing this.

The good news though is that @cpoile has sent a fix already which should be in the upcoming Mobile app release (both in 1.51.2 and 1.52.0). Once that's out you can ask your users to update which should finally eliminate the error logs.

@dalenewman
Copy link
Author

dalenewman commented May 6, 2022 via email

@cpoile
Copy link
Member

cpoile commented May 6, 2022

Hi @dalenewman, the fixed mobile app is in the app store now -- v1.51.2. v1.52.0 will also have the fix when it's released later this month. Those users who upgrade will not generate the server messages you mentioned above. Thanks for your patience while we fixed it!

@streamer45
Copy link
Contributor

Closing this as fixed.

@cpoile cpoile removed their assignment May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants