[MM-42385] Set title to popout window #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
commented
Mar 9, 2022
webapp/src/index.tsx
Outdated
| const otherID = getUserIdFromDM(channel.name, getCurrentUserId(store.getState())); | ||
| const dmUser = getUser(store.getState(), otherID); | ||
| if (!dmUser) { | ||
| await getProfilesByIdsAction([otherID])(store.dispatch as any, store.getState); |
There was a problem hiding this comment.
Not a fan of using any but I hit this issue before and my still fairly limited Typescript/React knowledge couldn't get to an easy solution.
Error was the following:
src/index.tsx:438:61 - error TS2345: Argument of type 'Dispatch<AnyAction>' is not assignable to parameter of type 'DispatchFunc'.
Types of parameters 'action' and 'action' are incompatible.
Type 'Action' is not assignable to type 'AnyAction'.
Property 'type' is missing in type 'ActionFunc' but required in type 'AnyAction'.
438 await getProfilesByIdsAction([otherID])(store.dispatch, store.getState);
~~~~~~~~~~~~~~
node_modules/redux/index.d.ts:19:3
19 type: T
~~~~
'type' is declared here.
There was a problem hiding this comment.
Do you mind if I push a commit? It will add redux-thunk to the dev dependencies and simplify this a bit?
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR sets a more descriptive title to the pop-out window to be more easily identifiable.
Title format is
Call - $channel_display_name. In case of DM, the username of the other participant is used instead./cc @aaronrothschild
Ticket Link
https://mattermost.atlassian.net/browse/MM-42385