Fix failing e2e test #335
Merged
Fix failing e2e test #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
commented
Feb 15, 2023
Comment on lines
+9
to
+11
| timeout: 30 * 1000, | ||
| expect: { | ||
| timeout: 30 * 1000, | ||
| timeout: 10 * 1000, |
There was a problem hiding this comment.
Unrelated but lowering some timeouts after the latest issue which took way too long cause of these being so high.
cpoile
approved these changes
Feb 15, 2023
| @@ -393,7 +393,7 @@ test.describe('switching products', () => { | |||
| await expect(devPage.page.locator('#calls-widget')).toBeVisible(); | |||
|
|
|||
| await devPage.page.locator('#calls-widget-participants-button').click(); | |||
| const participantsList = devPage.page.locator('#calls-widget-participants-menu'); | |||
| const participantsList = devPage.page.locator('#calls-widget-participants-list'); | |||
There was a problem hiding this comment.
Just curious, what did boards due to affect this?
There was a problem hiding this comment.
No idea to be honest I just wanted to fix it fast. Maybe something on .Menu class again. But it started failing all of the sudden, I guess it could have been webapp as well, didn't investigate further.
|
I have no idea why the pipeline fails to be honest. Plugin is building fine but somehow it breaks at uploading the npm cache. I'll try to trigger it once more but otherwise will merge this. |
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing some new failures after the latest boards/webapp update 馃槵