Handle screen permissions error to hide component #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an issue in handling the request from the desktop side in the
ScreenSourceModal
component since in case of an error we wouldn't show the modal but its state would still be open. Handling the error fixes this so that if users hide the "no permissions" banner and try again to share they will get it again, as expected.To note, I think we should be changing the error message if we are on desktop since the "cancelled" part doesn't apply there.
Related PR
mattermost/desktop#2556