[MM-54445] Review metrics #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Sep 13, 2023
streamer45
added
3: Reviews Complete
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
========================================
+ Coverage 5.35% 5.42% +0.06%
========================================
Files 24 24
Lines 4387 4387
========================================
+ Hits 235 238 +3
+ Misses 4134 4132 -2
+ Partials 18 17 -1
☔ View full report in Codecov by Sentry. |
This was referenced Nov 1, 2023
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Porting the fix in #523 to the main branch as well. The rtcd update will happen naturally at a later time when we release v0.12.0 so not including that yet.
Ticket Link
https://mattermost.atlassian.net/browse/MM-54445