Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-48545] Fix response in case of resumable upload #642

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

streamer45
Copy link
Contributor

Summary

Fixing the response handler in case of http.StatusNoContent which we support as part of the resumable upload handler for recordings. Without this we'd get an annoying http: request method or response status code does not allow body error logged.

Ticket Link

https://mattermost.atlassian.net/browse/MM-48545

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Feb 20, 2024
@streamer45 streamer45 added this to the v0.25.0 / MM 9.7 milestone Feb 20, 2024
@streamer45 streamer45 self-assigned this Feb 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e1e08bc) 9.30% compared to head (f5cbbf2) 9.36%.

Files Patch % Lines
server/audit.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #642      +/-   ##
========================================
+ Coverage   9.30%   9.36%   +0.05%     
========================================
  Files         26      26              
  Lines       5308    5309       +1     
========================================
+ Hits         494     497       +3     
+ Misses      4761    4760       -1     
+ Partials      53      52       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 28, 2024
@streamer45 streamer45 merged commit 6b610aa into main Feb 29, 2024
6 checks passed
@streamer45 streamer45 deleted the MM-48545 branch February 29, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants