Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-54971] Implement missing tooltips #644

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[MM-54971] Implement missing tooltips #644

merged 1 commit into from
Feb 29, 2024

Conversation

streamer45
Copy link
Contributor

Summary

PR adds missing tooltips to some of our buttons:

  • Settings wheel (widget)
    • image
  • Expand icon (open pop out window)
    • image
  • Collapse icon (close pop out window)
    • image

@matthewbirtch Noting that none of the above have a respective keyboard shortcut assigned. Let me know if it's something we should address in which case we may as well do it here.

Ticket Link

https://mattermost.atlassian.net/browse/MM-54971

@streamer45 streamer45 added 1: UX Review Requires review by ux 2: Dev Review Requires review by a core committer labels Feb 27, 2024
@streamer45 streamer45 added this to the v0.25.0 / MM 9.7 milestone Feb 27, 2024
@streamer45 streamer45 self-assigned this Feb 27, 2024
Copy link
Contributor

@matthewbirtch matthewbirtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @streamer45. Thanks for adding these.

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 1: UX Review Requires review by ux 2: Dev Review Requires review by a core committer labels Feb 28, 2024
@streamer45 streamer45 merged commit 0d7e31c into main Feb 29, 2024
6 checks passed
@streamer45 streamer45 deleted the MM-54971 branch February 29, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants