Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-51852] Update server version to min version that has MM-51852 #650

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Mar 4, 2024

Summary

Ticket Link

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Mar 4, 2024
@cpoile cpoile requested a review from streamer45 March 4, 2024 20:12
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.34%. Comparing base (94d51dc) to head (60b4784).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #650   +/-   ##
=====================================
  Coverage   9.34%   9.34%           
=====================================
  Files         26      26           
  Lines       5318    5318           
=====================================
  Hits         497     497           
  Misses      4769    4769           
  Partials      52      52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45
Copy link
Contributor

Wondering if we should bump to latest ESR (v9.5) since we are at it. Most customers would jump to that one when they reach v9.

@streamer45 streamer45 added this to the v0.25.0 / MM 9.7 milestone Mar 4, 2024
@cpoile
Copy link
Member Author

cpoile commented Mar 4, 2024

@streamer45 I thought it was more of a "this is the bare minimum you need" kind of thing, not a "we recommend you be on this ESR for various other reasons." But if you prefer, I don't mind either way.

@streamer45
Copy link
Contributor

streamer45 commented Mar 4, 2024

@streamer45 I thought it was more of a "this is the bare minimum you need" kind of thing, not a "we recommend you be on this ESR for various other reasons." But if you prefer, I don't mind either way.

That's correct but we also have a somewhat important security fix we merged recently (#620) which doesn't really work before 9.5 either. So maybe there's a chance to align with ESRs going forward.

Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 5, 2024
@streamer45 streamer45 merged commit dba82a9 into main Mar 8, 2024
6 checks passed
@streamer45 streamer45 deleted the MM-51852-update-min-server-version branch March 8, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants