Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-57102 Update phone icon on channel header call button #652

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

matthewbirtch
Copy link
Contributor

Summary

Changes the icon on the call button to be the filled phone icon instead of the outlined phone icon.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-57102

Screenshots

Before After
image image

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Mar 5, 2024
@cpoile cpoile added this to the v0.25.0 / MM 9.7 milestone Mar 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.34%. Comparing base (94d51dc) to head (51a8a12).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #652   +/-   ##
=====================================
  Coverage   9.34%   9.34%           
=====================================
  Files         26      26           
  Lines       5318    5318           
=====================================
  Hits         497     497           
  Misses      4769    4769           
  Partials      52      52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 5, 2024
@matthewbirtch
Copy link
Contributor Author

@cpoile are we good to merge? I assume this doesn't need QA

@cpoile cpoile merged commit 6eb61b4 into main Mar 5, 2024
6 checks passed
@cpoile cpoile deleted the button-phone-icon branch March 5, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants