Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chinese language code mapping #653

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix Chinese language code mapping #653

merged 1 commit into from
Mar 8, 2024

Conversation

streamer45
Copy link
Contributor

Summary

After some discussion https://community.mattermost.com/core/pl/b8cans4gy7b6fyw9jkstyfp7wr we re-map certain codes to the language files we provide instead of duplicating them.

Fixes #651

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Mar 6, 2024
@streamer45 streamer45 added this to the v0.25.0 / MM 9.7 milestone Mar 6, 2024
@streamer45 streamer45 requested a review from cpoile March 6, 2024 22:23
@streamer45 streamer45 self-assigned this Mar 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.34%. Comparing base (6eb61b4) to head (0b28bfc).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #653   +/-   ##
=====================================
  Coverage   9.34%   9.34%           
=====================================
  Files         26      26           
  Lines       5318    5318           
=====================================
  Hits         497     497           
  Misses      4769    4769           
  Partials      52      52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 6, 2024
@streamer45 streamer45 merged commit d21f4da into main Mar 8, 2024
6 checks passed
@streamer45 streamer45 deleted the fix-chinese branch March 8, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plugin does not apply the language set by the user
3 participants