Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid manifest type #686

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix invalid manifest type #686

merged 1 commit into from
Apr 10, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Apr 10, 2024

Summary

  • string -> text, oops

Ticket Link

  • none

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Apr 10, 2024
@cpoile cpoile requested a review from streamer45 April 10, 2024 20:40
streamer45
streamer45 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't blame you

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 10, 2024
@streamer45 streamer45 added this to the v0.26.0 / MM 9.8 milestone Apr 10, 2024
@cpoile
Copy link
Member Author

cpoile commented Apr 10, 2024

@streamer45 😭

@cpoile cpoile merged commit c536f09 into main Apr 10, 2024
4 checks passed
@cpoile cpoile deleted the fix-manifest branch April 10, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.26.2 / MM 9.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpoile @streamer45