Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fails #11

Closed
hanzei opened this issue Sep 22, 2018 · 0 comments · Fixed by #12
Closed

Make fails #11

hanzei opened this issue Sep 22, 2018 · 0 comments · Fixed by #12

Comments

@hanzei
Copy link
Contributor

hanzei commented Sep 22, 2018

Running just make fails with:

make: *** No rule to make target '.npminstall', needed by 'check-style'. Stop.

I think, https://github.com/mattermost/mattermost-plugin-github/blob/master/Makefile#L8 should be changed to check-style: webapp/.npminstall gofmt
@hanzei hanzei mentioned this issue Sep 22, 2018
Merged
IndushaS pushed a commit to IndushaS/mattermost-plugin-github that referenced this issue Feb 8, 2021
@gabrieljackson
Add auth proxy support (mattermost#11)
82e6d09 
This change introduces auth proxy support for our AWS API Gateway
configuration.

This also updates the Mattermost API client used for compatibility
with newer versions of Mattermost.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix makefile
1 participant
@hanzei