Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a user deletes a comment, you receive a notification for a comment creation #48

Closed
DSchalla opened this issue Feb 20, 2019 · 0 comments
Closed

If a user deletes a comment, you receive a notification for a comment creation #48

DSchalla opened this issue Feb 20, 2019 · 0 comments
Labels
Help Wanted Community help wanted

Comments

@DSchalla
Copy link
Member

Description:
When a user is deleting comments on a PR e.g., you will be notified that the user posted a new comment:

Example

Compared to:
mattermost/mattermost-webapp#2356

The "Comment created" from @jasonblais are actually comment deletes.

Actual Behavior:
Comment deletion being shown as comment creation

Expected Behavior:
Comment deletion being shown as comment deletion
@jwilander jwilander added bug Help Wanted Community help wanted labels Feb 20, 2019
@checkaayush checkaayush mentioned this issue Mar 24, 2019
Merged
jwilander pushed a commit that referenced this issue Mar 25, 2019
@checkaayush @jwilander
Fix #48: Use IssueCommentEvent's action in post msg (#63)
5890626 
* Fix #48: Use IssueCommentEvent's action in post msg

* Remove notification on comment edit/delete
IndushaS pushed a commit to IndushaS/mattermost-plugin-github that referenced this issue Feb 8, 2021
@jwilander
Default cloud servers to use aws multitenant (mattermost#48)
df45ca1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Community help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwilander @DSchalla