Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not post a daily reminder if there are no updates #90

Closed
jasonblais opened this issue Jun 5, 2019 · 1 comment
Closed

Do not post a daily reminder if there are no updates #90

jasonblais opened this issue Jun 5, 2019 · 1 comment
Labels
Help Wanted Community help wanted

Comments

@jasonblais
Copy link
Contributor

When there are no updates, the plugin sends a daily reminder with "no updates".

image

Propose not sending a daily reminder when there are no updates.
@jasonblais jasonblais added Enhancement Help Wanted Community help wanted labels Jun 5, 2019
@ivenk ivenk mentioned this issue Jun 7, 2019
Merged
@jasonblais jasonblais added the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 9, 2019
crspeller pushed a commit that referenced this issue Jun 14, 2019
@ivenk @crspeller
GH-90 Added checking for updates before sending daily update (#91)
c2c8a08 
* Added checking for news before sending daily update

* Renamed function, moved check in order to avoid network traffic when possible

* Filtering some spammy notifications.

* Fixed a bug. Changed behaviour on error.
@jasonblais
Copy link
Contributor Author

Thanks @ivenk!

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Community help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonblais @hanzei