Add "Attach to Github Issue" similar to Jira plugin

[niklabh]

Summary

Add "Attach to Github Issue" similar to Jira plugin
Here is the flow for implementations:

• Click Attach to Github Issue in context menu (shown when user connects his github account with plugin installed) on non system messages
  
• Attach to github modal will open
  
• You can search the issue. The query to github is is:open is:issue assignee:{connected_user} archived:false [org:{organisation}] [search term]
  
• Comment is attached to github
  

Issue

Fixes #119

[levb]

This is an awesome addition, @niklabh! Thank you for the contribution!

[aaronrothschild]

AHHHH-mazing! Looks great. Thank you @niklabh !

[mickmister]

Great work @niklabh! Just a few requested changes. Thank you for this great improvement!!

[mickmister]

LGTM, great work @niklabh!! 🎉

[jwilander]

Looks good, just a couple requests

[jwilander]

LGTM 👍

[mattermod]

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @hanzei

[hanzei]

@DHaussermann gentle reminder to review this

[DHaussermann]

Thanks for the contribution @niklabh. This addition to the functionality is great!
No issues found with the work in this PR. It is behaving as expected.

@aaronrothschild I do see some opportunities to add to this further that would improve the experience. Let me know of any of this would be worth adding and I can create separate issues.

1. When I attach a comment, I should get feedback that this was done successfully (Similar integrations post a reply with such a message and a link but, a simpler way to provide feedback wold work as well)
2. In the search results, ideally we would return the issue number in addition to the title to cover cases where there titles are similar. Though the issue numbers could overlap across multiple repos within the same list.
3. This design is limited to adding comments where the user is the assignee. There would also be value in adding comments to other issues as well. Would we need a more complex design to handle cases where you select an issue and don'y have permissions to comment?

[aaronrothschild]

@niklabh see my comments inline

@aaronrothschild I do see some opportunities to add to this further that would improve the experience. Let me know of any of this would be worth adding and I can create separate issues.

1. When I attach a comment, I should get feedback that this was done successfully (Similar integrations post a reply with such a message and a link but, a simpler way to provide feedback wold work as well)

Yes, I've had a few instances where the confirmation is re-assuring - certainly during the first experience. I agree with @DHaussermann , the utility of having the link referenced within the conversation is pretty critical to the long-term user experience. Over time, without the reference to the attached issue, a critical piece of development conversations can get lost. it also serves the dual purpose of confirming that it was successful in attaching to the issue. I'm 4/5 we should add this before merge.

2. In the search results, ideally we would return the issue number in addition to the title to cover cases where there titles are similar. Though the issue numbers could overlap across multiple repos within the same list.

This request has come up from a few different customers that use the equivalent function in the Jira plugin. Displaying the issue numbers clears ambiquity and lets the user be confident they chose the right option/value. Not sure how much effort is involved.

3. This design is limited to adding comments where the user is the assignee. There would also be value in adding comments to other issues as well. Would we need a more complex design to handle cases where you select an issue and don'y have permissions to comment?

Hmmm. Not sure about this one, could we even accomodate a scenario where we couldn't post as the user (b/c permissions)?

[mickmister]

@aaronrothschild This PR is already merged. Adding the link in a post will have to be a separate PR.