Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to refresh RHS details #138

Closed
wants to merge 6 commits into from
Closed

add ability to refresh RHS details #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1fd0d1e
add ability to refresh RHS details
manland Oct 7, 2019
74826bf
fix code with review comments : use hooks
manland Oct 16, 2019
9b064d8
add jest to test code and debug
manland Oct 24, 2019
9c59567
update css color of refresh button
manland Oct 24, 2019
d3f2c44
make eslint happy
manland Oct 24, 2019
928266c
Merge branch 'master' into 131-refreshRhs
lieut-data Oct 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
dist
.DS_STore
node_modules
node_modules
.vscode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a new line here

2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ ifneq ($(HAS_SERVER),)
$(GO) test -race -v ./server/...
endif
ifneq ($(HAS_WEBAPP),)
cd webapp && $(NPM) run fix;
cd webapp && $(NPM) run fix && $(NPM) test;
endif

## Creates a coverage report for the server code.
Expand Down
8 changes: 8 additions & 0 deletions webapp/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@
"settings": {
"import/resolver": "webpack"
},
"overrides": [
{
"files": ["tests/setup.js"],
"rules": {
"no-console": "off"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? I believe this is turned on by default on all repos

}
}
],
"rules": {
"array-bracket-spacing": [
2,
Expand Down
6 changes: 6 additions & 0 deletions webapp/babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.

module.exports = {
presets: ['@babel/preset-env', '@babel/preset-react'],
};
Loading