[GH-139] octopus icon randomly changes where it points to

[larkox]

Summary:
Fix "octopus icon randomly changes where it points to"

Issue link:
Fixes #139

[crspeller]

Good fix!

[DHaussermann]

This is performing as expected when no Enterprise Base URL is configure but, I'm unsure of how I can validate this when there is an Enterprise Base URL in place.

I can add a token URL to the config and hit refresh to see the icon pointing to it but I can't validate that it works while having a connected user. @crspeller does Mattermost have an enterprise URL I may not be aware of?

[crspeller]

@jwilander Did we get something to test the GitHub enterprise integration?

[jwilander]

I'm part of the GitHub Enterprise developer program which is how I tested this stuff in the past. I don't have that instance running anymore though unfortunately

It's pretty easy to get into the developer program and spin up an instance though. Might be a good idea to have a "permanent" instance for testing the plugin

[DHaussermann]

I have done the regression testing I can do without an Enterprise URL and confirmed with a token URL that the "Octocat" icon point to it correctly.

I suggest merging this. We could then post in #139 and see if someone can confirm the fix before we package a release for the plugin.