Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge FEATURE-create-issue-modal into master #239
Merge FEATURE-create-issue-modal into master #239
Changes from all commits
96f8770
763816b
e7c21fa
f6c2182
e81835b
ca37b05
1aa6563
1194c2d
fc19f20
4e7e89e
8b6718b
65788bd
722c7ac
d2a2076
ce678a8
f8f4fdd
0cabd95
aa1f643
c1d7b37
e4ed032
8dad1cd
529e46e
a7b9d3c
f4a1cc3
7644332
4bcb03f
dea3276
495aae1
0f9ec54
de0e8b9
003d748
fb1609e
40378f2
eab01f5
85b7fcb
ef63090
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are exiting this function without writing to the response. Is this intended? It also happens in the
else
block below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no consistent error handling in the code. Returning there just lead to an empty response, which is not wrong. There is room for improvement, but I need to think about it and there are more important issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanzei I want to know why this is the case. If we don't call
Write
orWriteHeader
(or an equivalent), how does the response get closed? Is it something that the server does automatically for us? Maybe it's my mis-understanding of how http requests are handled in Go.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is part of the
http
package. OnceServeHTTP
terminates and not header has been written, 200 gets send as a response.Mini example: