Add Autocomplete icon

[hanzei]

Summary

The icon doesn't look optimal on a dark theme. @asaadmahmood I'm wondering what you think about this.

Ticket Link

Fixes #358

[hanzei]

DisplayName and Description are not needed for plugins as they are not shown.

[codecov-commenter]

Codecov Report

Merging #359 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   20.15%   20.10%   -0.05%     
==========================================
  Files          11       11              
  Lines        2615     2621       +6     
==========================================
  Hits          527      527              
- Misses       2050     2056       +6     
  Partials       38       38              

Impacted Files	Coverage Δ
server/plugin/command.go	14.07% <0.00%> (-0.16%)	⬇️
server/plugin/configuration.go	28.12% <0.00%> (-2.91%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351e078...5cd2806. Read the comment docs.

[hanzei]

Heads up: The code might be replaced by the one in mattermost/mattermost-plugin-api#71 if the PR gets accepted.

[asaadmahmood]

@hanzei We should use the same github image as we use for the Github bot.
The Github bot image that we use has a white background behind it.

[hanzei]

@asaadmahmood In the Marketplace modal we put a white background behind every icon. I was wondering we we want to do the same here and don't task the developer with providing the background.

[asaadmahmood]

@hanzei We can do that, but we would still have to use a different image that has a padding built in. So that the image is not too close to the edges of the white background.
I would lean towards not having a white background, just in case people intentionally want to keep the bg transparent.

[hanzei]

Do we have to have a different image? This is how it looks in the Marketplace with the same svg used as in this PR.

[asaadmahmood]

@hanzei Here's the image in our Github bot avatar, we can use this.

[hanzei]

As per request from @asaadmahmood I've updated the icon to use one with a white background:

[hanzei]

@asaadmahmood Does this look good to you?

[asaadmahmood]

Yup, looks good.

[DHaussermann]

• Icon always displays as expected
• Checked icon looks good on all themes
• Tested on desktop and various browsers

@hanzei This change is working but, something is odd about the unit tests. Can you please take a look?

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        4.118 s
Ran all test suites.
cd ./build/sync && /usr/local/go/bin/go test -v -race ./...
go: warning: "./..." matched no packages
no packages to test
make: *** [test] Error 1

[hanzei]

@DHaussermann #363 will fix the failure in make test. That issue is unrelated to this PR.

[DHaussermann]

Tested and Passed
Only one issue was found in testing. It is unrelated and will be addressed separately.

LGTM!

[hanzei]

Waiting for #363 to be merged first.