Added setting to hide/show left sidebar github buttons #396

jatinkksharma · 2020-10-20T09:23:36Z

Mattermost github plugin issue - #384

mattermod · 2020-10-20T09:23:40Z

Hello @jatinjtg,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

aaronrothschild

Thanks for your contribution @jatinjtg ! Some small text description changes, because many people don't know what the "LHS" of Left Hand Sidebar. I added text to explain what the feature is doing.

plugin.json

server/plugin/manifest.go

plugin.json

webapp/src/manifest.ts

Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>

larkox

Thanks for the contribution. Just 2 comments.

server/plugin/api.go

webapp/src/index.js

codecov-io · 2020-10-20T14:19:40Z

Codecov Report

Merging #396 (920dc70) into master (4b4bc21) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   19.34%   19.35%           
=======================================
  Files          11       11           
  Lines        2766     2770    +4     
=======================================
+ Hits          535      536    +1     
- Misses       2193     2196    +3     
  Partials       38       38

Impacted Files	Coverage Δ
server/plugin/configuration.go	`28.12% <ø> (ø)`
server/plugin/manifest.go	`100.00% <ø> (ø)`
server/plugin/api.go	`7.54% <25.00%> (+0.08%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4bc21...920dc70. Read the comment docs.

hanzei

LGTM. A few comments on ordering

hanzei · 2020-10-21T10:32:40Z

server/plugin/api.go

@@ -130,6 +134,7 @@ func (p *Plugin) initializeAPI() {

 	apiRouter.HandleFunc("/config", checkPluginRequest(p.getConfig)).Methods(http.MethodGet)
 	apiRouter.HandleFunc("/token", checkPluginRequest(p.getToken)).Methods(http.MethodGet)
+	apiRouter.HandleFunc("/settings", p.getSettings).Methods(http.MethodGet)


Could you please move this after apiRouter.HandleFunc("/connected", p.getConnected).Methods(http.MethodGet) to keep the list sorted by middle ware type?

It seems like that change wasn't pushed. Could you please double check?

Sorry @hanzei for late reply. I have fixed the ordering.

plugin.json

server/plugin/configuration.go

mattermod · 2020-10-31T01:01:06Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

jfrerich · 2020-10-31T14:32:05Z

Thanks for the PR, @jatinjtg! Do you need any assistance regarding the PR feedback?

hanzei

Nice work, LGTM 👍

mattermod · 2021-01-26T01:01:04Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

jfrerich · 2021-01-26T16:46:52Z

@DHaussermann, gentle ping for review~

DHaussermann · 2021-01-28T14:58:48Z

/update-branch

mattermod · 2021-01-28T14:58:50Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

DHaussermann · 2021-01-28T14:59:38Z

@jfrerich - Not sure if there are many changes since the initial submission. Are you able to merge master in?

jfrerich · 2021-02-01T16:02:23Z

I don't have the ability to merge master into the author's repo. I created a branch in the mattermost repo that includes merged master into this branch. You can test this if you'd like.. https://github.com/mattermost/mattermost-plugin-github/commits/left_sidebar

These are the steps I took. to create the testable branch of this PR, with the latest master merged

From inside mattermost/mattermost-plugin-github

git checkout master
git pull
hub pr checkout 396
git merge master

hanzei · 2021-02-08T11:40:11Z

@DHaussermann You can just test this PR as it is. There is to eminent need to sync it.

DHaussermann

Tested and working as expected.

Options show and hide as expected
Works for one team with horizontal bar on LHS and for team sidebar
Work for octocat icon when user is not connected
New flag to show options default to true for seamless upgrade

Thanks @jamiehurewitz for this PR!

Not blocking for this change but @aaronrothschild, as described in this task, the flag hides the LHS and team sidebar items. We would need a separate PR if the goal is to hide all UI elements.

hanzei · 2021-02-11T12:01:31Z

/update-branch

mattermod · 2021-02-11T12:01:32Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

hanzei · 2021-02-11T12:02:28Z

Thanks @jatinjtg for the contribution!

aaronrothschild · 2021-02-12T14:15:59Z

@chetanyakan Can you verify for me that you just wanted the LHS to be hidden by a system level setting? In Jira, we hide all webapp components (including the post-action message to log a Jira ticket in the drop down menu).

Is hiding the LHS notifications sufficient for your request or do we need another ticket to cover "hiding the post-action menu item to create New/Attach GitHub issues"

chetanyakan · 2021-02-15T06:25:36Z

@aaronrothschild Thanks for confirming. Another ticket for further changes is not required at the moment.

The changes from this PR are enough to satisfy my requirements for the time being, since having multiple plugins that register an LHS component is not as obtrusive anymore.

add logic to hide/show left github sidebar actions

8a640bf

jatinkksharma requested a review from hanzei as a code owner October 20, 2020 09:23

mattermod added Hacktoberfest hacktoberfest-accepted labels Oct 20, 2020

jatinkksharma changed the title ~~Added setting to hide/show left github sidebar actions~~ Added setting to hide/show left sidebar github actions Oct 20, 2020

update help text

13d3d13

jatinkksharma changed the title ~~Added setting to hide/show left sidebar github actions~~ Added setting to hide/show left sidebar github buttons Oct 20, 2020

aaronrothschild approved these changes Oct 20, 2020

View reviewed changes

jatinkksharma and others added 3 commits October 20, 2020 17:07

Update plugin.json

a6f5e22

Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>

Update server/plugin/manifest.go

0e0e65c

Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>

Update server/plugin/manifest.go

be75ceb

Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>

jasonblais requested a review from larkox October 20, 2020 11:38

jasonblais added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 20, 2020

jatinkksharma and others added 3 commits October 20, 2020 17:08

Update plugin.json

78a6088

Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>

Update webapp/src/manifest.ts

7701e54

Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>

Update webapp/src/manifest.ts

d8cb867

Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>

hanzei linked an issue Oct 20, 2020 that may be closed by this pull request

Proposal - Add a system console setting to allow disabling UI components #384

Closed

larkox requested changes Oct 20, 2020

View reviewed changes

server/plugin/api.go Outdated Show resolved Hide resolved

webapp/src/index.js Show resolved Hide resolved

add type for settings

fd89f83

hanzei requested changes Oct 21, 2020

View reviewed changes

mattermod added the Lifecycle/1:stale label Oct 31, 2020

fix ordering

a1c45d6

jatinkksharma requested review from hanzei, aaronrothschild and larkox October 31, 2020 16:25

mattermod added the Lifecycle/1:stale label Dec 29, 2020

jasonblais removed the Lifecycle/1:stale label Jan 7, 2021

hanzei approved these changes Jan 14, 2021

View reviewed changes

hanzei removed the 2: Dev Review Requires review by a core committer label Jan 14, 2021

hanzei requested review from DHaussermann and removed request for aaronrothschild January 14, 2021 16:00

hanzei added the Docs/Not Needed Does not require documentation label Jan 14, 2021

mattermod added the Lifecycle/1:stale label Jan 26, 2021

DHaussermann approved these changes Feb 10, 2021

View reviewed changes

DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Lifecycle/1:stale labels Feb 10, 2021

hanzei added this to the v2.1.0 milestone Feb 11, 2021

hanzei self-assigned this Feb 11, 2021

hanzei merged commit f46f8f4 into mattermost:master Feb 11, 2021

hanzei removed their assignment Feb 11, 2021

chetanyakan deleted the left_sidebar branch February 15, 2021 06:25

mickmister mentioned this pull request Jan 26, 2022

Hide Toolbar mattermost/mattermost-plugin-gitlab#234

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added setting to hide/show left sidebar github buttons #396

Added setting to hide/show left sidebar github buttons #396

jatinkksharma commented Oct 20, 2020

mattermod commented Oct 20, 2020

aaronrothschild left a comment

larkox left a comment

codecov-io commented Oct 20, 2020 •

edited

Loading

hanzei left a comment

hanzei Oct 21, 2020

jatinkksharma Oct 31, 2020

hanzei Nov 3, 2020

jatinkksharma Dec 17, 2020

mattermod commented Oct 31, 2020

jfrerich commented Oct 31, 2020

hanzei left a comment

mattermod commented Jan 26, 2021

jfrerich commented Jan 26, 2021

DHaussermann commented Jan 28, 2021

mattermod commented Jan 28, 2021

DHaussermann commented Jan 28, 2021

jfrerich commented Feb 1, 2021 •

edited

Loading

hanzei commented Feb 8, 2021

DHaussermann left a comment

hanzei commented Feb 11, 2021

mattermod commented Feb 11, 2021

hanzei commented Feb 11, 2021

aaronrothschild commented Feb 12, 2021

chetanyakan commented Feb 15, 2021

Added setting to hide/show left sidebar github buttons #396

Added setting to hide/show left sidebar github buttons #396

Conversation

jatinkksharma commented Oct 20, 2020

mattermod commented Oct 20, 2020

aaronrothschild left a comment

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

codecov-io commented Oct 20, 2020 • edited Loading

Codecov Report

hanzei left a comment

Choose a reason for hiding this comment

hanzei Oct 21, 2020

Choose a reason for hiding this comment

jatinkksharma Oct 31, 2020

Choose a reason for hiding this comment

hanzei Nov 3, 2020

Choose a reason for hiding this comment

jatinkksharma Dec 17, 2020

Choose a reason for hiding this comment

mattermod commented Oct 31, 2020

jfrerich commented Oct 31, 2020

hanzei left a comment

Choose a reason for hiding this comment

mattermod commented Jan 26, 2021

jfrerich commented Jan 26, 2021

DHaussermann commented Jan 28, 2021

mattermod commented Jan 28, 2021

DHaussermann commented Jan 28, 2021

jfrerich commented Feb 1, 2021 • edited Loading

hanzei commented Feb 8, 2021

DHaussermann left a comment

Choose a reason for hiding this comment

hanzei commented Feb 11, 2021

mattermod commented Feb 11, 2021

hanzei commented Feb 11, 2021

aaronrothschild commented Feb 12, 2021

chetanyakan commented Feb 15, 2021

codecov-io commented Oct 20, 2020 •

edited

Loading

jfrerich commented Feb 1, 2021 •

edited

Loading