make Github icon url configurable #57
Conversation
|
I have no idea why that test fails |
|
Is there a way we could have the plugin host the image itself? Or for the client-side code to embed the image into the webpack bundle directly? Presumably this doesn't need to actually be "configurable", but just accessible without an internet connection. Or, @zetaab, were you hoping to allow changing it from the default logo? |
|
Yes I hope that i could change the url of the logo. This code works fine for me. I am now hosting that same image inside our internal network and it works fine. This feature also allows changing the bot icon if someone wants customize it |
lieut-data
added
1: PM Review
|
I do have a PR here for self-hosting the image from the plugin #50 However, I'm not opposed to making it configurable |
There was a problem hiding this comment.
I suspect majority of admins won't care about configuring the URL (they just want it to "work"), so I'd prefer the self-hosting option over making it configurable. Which #50 would cover, sounds like.
|
Agree with @jasonblais #50 is the solution to this. Thanks for the contribution, but going to close this. |
The cloud server now support single and multitenant PostgreSQL databases. This change adds both of these options and sets the default database to multitenant Postgres for new installations.
I installed 0.8 version today our mattermost, and now the problem is that Icon is not visible at all. This is because icon url is hardcoded to code, and our mattermost server cannot access to internet.
That is why I suggest that we make this url configurable