-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-686]:Fixed issue #686 'Pull Request Reviews are not posted' #689
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
=======================================
Coverage 15.51% 15.51%
=======================================
Files 15 15
Lines 5543 5543
=======================================
Hits 860 860
Misses 4641 4641
Partials 42 42
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one non-blocking suggestion
@Kshitij-Katiyar Can you please provide a gif of the feature working properly? Then we can merge here. Preferably before & after gif/screenshot but not required here |
@mickmister Please find the below videos before and after the changes |
Summary
Fixed the issue that When Pull Request Reviews are submitted (Comment, Approve, Change Requested), no message was appearing in the subscribed channel.
Issue #686