Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-686]:Fixed issue #686 'Pull Request Reviews are not posted' #689

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

  • Fixed the issue that When Pull Request Reviews are submitted (Comment, Approve, Change Requested), no message was appearing in the subscribed channel.

  • Issue #686

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (11815f8) 15.51% compared to head (d24702b) 15.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #689   +/-   ##
=======================================
  Coverage   15.51%   15.51%           
=======================================
  Files          15       15           
  Lines        5543     5543           
=======================================
  Hits          860      860           
  Misses       4641     4641           
  Partials       42       42           
Files Changed Coverage Δ
server/plugin/webhook.go 0.81% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 14, 2023
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one non-blocking suggestion

server/plugin/webhook.go Outdated Show resolved Hide resolved
@hanzei hanzei requested a review from mickmister August 14, 2023 10:22
@hanzei hanzei linked an issue Aug 14, 2023 that may be closed by this pull request
@hanzei hanzei added this to the v2.2.0 milestone Aug 14, 2023
@mickmister mickmister removed the 2: Dev Review Requires review by a core committer label Aug 15, 2023
@mickmister
Copy link
Member

mickmister commented Aug 15, 2023

@Kshitij-Katiyar Can you please provide a gif of the feature working properly? Then we can merge here. Preferably before & after gif/screenshot but not required here

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar Can you please provide a gif of the feature working properly? Then we can merge here. Preferably before & after gif/screenshot but not required here

@mickmister Please find the below videos before and after the changes
Before the changes.webm
After the changes.webm

@mickmister mickmister merged commit c31d053 into mattermost:master Aug 16, 2023
9 checks passed
@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull Request Reviews are not posted.
4 participants