Fixes #498: "Validation Message Should be User Friendly" #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrusjc
changed the title
hanzei
added
2: Dev Review
Kshitij-Katiyar
approved these changes
Apr 9, 2024
| this.setState({ | ||
| issueTitleValid: Boolean(this.state.issueTitle), | ||
| issueTitleValid: Boolean(isValidTitle), |
There was a problem hiding this comment.
@cyrusjc Thanks for the PR.
Here isValidTitle is already going to be a boolean value. Is there any need to type caste into a Boolean again?
There was a problem hiding this comment.
Ah no particular reason other than a small oversight on my part.
mickmister
approved these changes
Apr 23, 2024
mickmister
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
Just a quick client side change which checks if the trimmed length of issueTitle is 0.
We could add another error message that says "Please enter valid title" or something similar to that effect for further clarification but IMO this is enough.