[GHG-654] Added mentions on sidebar buttons / rhs bar #775
Conversation
cyrusjc
changed the title
…gin-github into cyrusjc/adding-mentions-to-sidebar
| style={button} | ||
| > | ||
| <i className='fa fa-comment-o'/> | ||
| {' ' + mentions.length} |
There was a problem hiding this comment.
I'm leaning towards not showing the number of mentions.
There are users who are keen on keeping their inboxes empty. Given that they have no control over this number and can't reduce it, I wonder if we should omit the number. The button would still allow the user to check in on their conversation but would no longer nag them.
There was a problem hiding this comment.
That's a good point. I think it makes sense to remove the number. Would we then want to change the ordering of the mentions icon? I was thinking since it would be just an icon we can move it next to the refresh button
There was a problem hiding this comment.
It would look something like this:
There was a problem hiding this comment.
@hanzei Is it possible to "remove" mentions? Maybe unsubscribing to the issue/PR does this?
There was a problem hiding this comment.
It would look something like this:
I like the suggestion 👍
hanzei
added
2: Dev Review
Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>
consistency renaming Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>
consistency renaming Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>
|
@cyrusjc There are some merge conflicts to resolve due to a recent typescript PR merge. Can you please take a look at them? Thanks for your work on this!! 😄 |
…gin-github into cyrusjc/adding-mentions-to-sidebar
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Closes #654
Summary:
Added mention icon and associated information in the RHS bar for the mentions in PRs as suggested in the issue.
Changes looks like:
