Skip to content

Commit

Permalink
fix rudder key secret name (#369)
Browse files Browse the repository at this point in the history
After some name changing, MM_RUDDER_WRITE_KEY has become MM_RUDDER_PLUGINS_PROD.

Fix custom.mk so we get the right data.
  • Loading branch information
trilopin committed Mar 30, 2023
1 parent 5adb3d0 commit 2b10e7c
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions build/custom.mk
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
# Include custom targets and environment variables here

ifndef MM_RUDDER_WRITE_KEY
MM_RUDDER_WRITE_KEY = 1d5bMvdrfWClLxgK1FvV3s4U1tg
# If there's no MM_RUDDER_PLUGINS_PROD, add DEV data
RUDDER_WRITE_KEY = 1d5bMvdrfWClLxgK1FvV3s4U1tg
ifdef MM_RUDDER_PLUGINS_PROD
RUDDER_WRITE_KEY = $(MM_RUDDER_PLUGINS_PROD)
endif
GO_BUILD_FLAGS += -ldflags '-X "github.com/mattermost/mattermost-plugin-api/experimental/telemetry.rudderWriteKey=$(MM_RUDDER_WRITE_KEY)"'
GO_BUILD_FLAGS += -ldflags '-X "github.com/mattermost/mattermost-plugin-api/experimental/telemetry.rudderWriteKey=$(RUDDER_WRITE_KEY)"'


## Generates mock golang interfaces for testing
.PHONY: mock
Expand All @@ -12,4 +15,4 @@ ifneq ($(HAS_SERVER),)
go install github.com/golang/mock/mockgen@v1.6.0
mockgen -destination server/mocks/mock_gitlab.go github.com/mattermost/mattermost-plugin-gitlab/server/gitlab Gitlab
mockgen -destination server/gitlab/mocks/mock_gitlab.go github.com/mattermost/mattermost-plugin-gitlab/server/gitlab Gitlab
endif
endif

0 comments on commit 2b10e7c

Please sign in to comment.