Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use siteurl on webapp to avoid issues with subpath #177

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

mickmister
Copy link
Member

Ticket Link

Fixes #176

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 5, 2020
@mickmister mickmister requested review from manland and larkox June 5, 2020 07:32
@mickmister mickmister requested a review from iomodo as a code owner June 5, 2020 07:32
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   39.89%   39.89%           
=======================================
  Files          16       16           
  Lines        1494     1494           
=======================================
  Hits          596      596           
  Misses        838      838           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cc3324...d6325ad. Read the comment docs.

@hanzei hanzei added this to the v1.2.0 milestone Jun 8, 2020
Copy link
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Jun 8, 2020
@hanzei hanzei requested a review from DHaussermann June 9, 2020 14:16
@hanzei hanzei mentioned this pull request Jun 9, 2020
@DHaussermann
Copy link

@iomodo if you have time, is this something you would be able to peer test using the peer testing process documented here?https://mattermost.atlassian.net/wiki/spaces/INT/pages/619937892/Peer+Testing+Process

@iomodo
Copy link
Contributor

iomodo commented Jun 15, 2020

@DHaussermann tested, works as expected.

@mickmister
Copy link
Member Author

@DHaussermann Good to merge this?

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks to @iomodo for testing on this
I added a test for this to release testing
I Will include this is release testing for the next GitLab release
LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jun 16, 2020
@hanzei hanzei merged commit 1353595 into master Jun 16, 2020
@hanzei hanzei deleted the webapp-site-url branch June 16, 2020 07:13
@iomodo iomodo mentioned this pull request Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin not working in subpath ( domain.org/mattermost/ )
6 participants