-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use siteurl on webapp to avoid issues with subpath #177
Conversation
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 39.89% 39.89%
=======================================
Files 16 16
Lines 1494 1494
=======================================
Hits 596 596
Misses 838 838
Partials 60 60 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iomodo if you have time, is this something you would be able to peer test using the peer testing process documented here?https://mattermost.atlassian.net/wiki/spaces/INT/pages/619937892/Peer+Testing+Process |
@DHaussermann tested, works as expected. |
@DHaussermann Good to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge thanks to @iomodo for testing on this
I added a test for this to release testing
I Will include this is release testing for the next GitLab release
LGTM!
Ticket Link
Fixes #176