-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-37922 - Add support for Chimera to GitLab plugin #255
Conversation
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 39.78% 39.38% -0.40%
==========================================
Files 16 16
Lines 1757 1795 +38
==========================================
+ Hits 699 707 +8
- Misses 984 1011 +27
- Partials 74 77 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @Szymongib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
.gitignore
Outdated
|
||
# IDEs | ||
/.idea | ||
/.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit pick: Unrelated change
@DHaussermann See mattermost/mattermost-plugin-github#467 (comment) of for the tests steps. |
@DHaussermann Kind reminder to help with QA review. Similar to mattermost/mattermost-plugin-github#467, we'd like to get ready to ship the changes ahead of the Oct 13 launch, and would be happy to help where we can. As an aside, I wonder if Demansol would be equipped to help test the changes here or at mattermost/mattermost-plugin-github#467? |
To align with the implementation of the GitHub plugin and support both v5 and v6 servers I have added a fallback to Chimera env var. For more context see: mattermost/mattermost-plugin-github#467 (comment) |
@Szymongib I have done a round of testing on this and it's looking good 👍
The only feedback I have is to add the same sentence to the config option as we have on GitHub |
@DHaussermann I have aligned the setting text with the GitHub plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Functional testing completed
- I know see the text change on config as expected
Thanks @Szymongib
LGTM!
Summary
Chimera Proxy is an easier way to connect plugins to external OAuth providers. It provides pre-registered OAuth applications allowing users to skip the app registration step.
Design doc: https://docs.google.com/document/d/1a1AzNwxrqA5bcVonZOVu94b4vV6tT4U7fDIKBwf_aUI/edit
This PR makes it possible to connect GitLab Plugin via Chimera. It introduces:
Ticket Link
https://mattermost.atlassian.net/browse/MM-37922