Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the link to get the pending reviews #260

Merged
merged 1 commit into from
Sep 27, 2021
Merged

fix the link to get the pending reviews #260

merged 1 commit into from
Sep 27, 2021

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Sep 14, 2021

Summary

Using the gitlab in our community deployment notice that it did not show any MR that I need to review, checking closely notice that we were using a wrong filter. this PR update the filter and using that I was able to see my pending MR to review

Ticket Link

n/a

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #260 (a5671ed) into master (c3dda74) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   39.78%   39.78%           
=======================================
  Files          16       16           
  Lines        1757     1757           
=======================================
  Hits          699      699           
  Misses        984      984           
  Partials       74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3dda74...a5671ed. Read the comment docs.

Copy link
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @cpanato

@iomodo iomodo requested a review from hanzei September 14, 2021 16:03
@iomodo iomodo added the 2: Dev Review Requires review by a core committer label Sep 14, 2021
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 27, 2021
@hanzei hanzei added this to the v1.4.0 milestone Sep 27, 2021
@hanzei hanzei added the Docs/Not Needed Does not require documentation label Sep 27, 2021
@hanzei
Copy link
Collaborator

hanzei commented Sep 27, 2021

Skipping QA review as this is a minor fix

@hanzei hanzei merged commit e4eb2c8 into master Sep 27, 2021
@hanzei hanzei deleted the fix_mr_review branch September 27, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants