Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.4.0 #262

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Release v1.4.0 #262

merged 1 commit into from
Oct 8, 2021

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Oct 5, 2021

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 5, 2021
@hanzei hanzei added this to the v1.4.0 milestone Oct 5, 2021
@hanzei hanzei requested a review from iomodo as a code owner October 5, 2021 08:48
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #262 (164ef61) into master (e8242a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   39.38%   39.38%           
=======================================
  Files          16       16           
  Lines        1795     1795           
=======================================
  Hits          707      707           
  Misses       1011     1011           
  Partials       77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8242a1...164ef61. Read the comment docs.

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Oct 6, 2021
DHaussermann
DHaussermann approved these changes Oct 7, 2021
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Ran through release tests
  • Tested new features such as Chimera proxy authentication and support for labels on subscriptions
  • Tested fix to notification when plugin is locked to a group
  • Tested plugin functions normally on 5.39.0 and 6.0.0-rc1
  • Version number correct at v1.4.0

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 7, 2021
@hanzei hanzei merged commit 5f463d2 into master Oct 8, 2021
@hanzei hanzei deleted the release_v1.4.0 branch October 8, 2021 13:17
hanzei pushed a commit that referenced this pull request Mar 22, 2023
@MatthewDorner @mickmister
[GH-262] Merge request approval subscription (#307)
ad1d267 
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iomodo iomodo iomodo approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

@mickmister mickmister Awaiting requested review from mickmister mickmister is a code owner

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanzei @iomodo @DHaussermann