Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path namespace for Job event handling #344

Merged
merged 4 commits into from
Jan 12, 2023
Merged

Fix path namespace for Job event handling #344

merged 4 commits into from
Jan 12, 2023

Conversation

spirosoik
Copy link
Member

Summary

The repository data are not included in the JobEvent and we can get the namespace only by the event.ProjectName field. This field doesn't match always the real url of the combinations [group]/[repo]

@spirosoik
Fix path namespace for Job event handling
6fedc88 
The repository data are not included in the `JobEvent` and we can get the namespace only
by the `event.ProjectName` field. This field doesn't match always the real url of the
combinations `[group]/[repo]`
@codecov
Copy link

codecov bot commented Dec 9, 2022 •
edited

Codecov Report

Base: 33.32% // Head: 33.39% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (0c9d115) compared to base (2275492).
Patch coverage: 54.54% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   33.32%   33.39%   +0.06%     
==========================================
  Files          21       21              
  Lines        2785     3468     +683     
==========================================
+ Hits          928     1158     +230     
- Misses       1748     2197     +449     
- Partials      109      113       +4
Impacted Files Coverage Δ
server/command.go 24.66% <ø> (+0.82%) ⬆️
server/webhook.go 40.11% <0.00%> (+0.11%) ⬆️
server/webhook/webhook.go 53.26% <53.84%> (-2.13%) ⬇️
server/webhook/jobs.go 81.48% <62.50%> (-5.76%) ⬇️
server/utils.go 66.66% <0.00%> (-6.31%) ⬇️
server/configuration.go 35.38% <0.00%> (-4.62%) ⬇️
server/webhook/tag.go 80.35% <0.00%> (-3.32%) ⬇️
server/webhook/pipeline.go 84.05% <0.00%> (-2.83%) ⬇️
server/webhook/push.go 82.25% <0.00%> (-2.06%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@spirosoik spirosoik marked this pull request as ready for review December 22, 2022 07:32
mickmister
mickmister approved these changes Dec 22, 2022
View reviewed changes
server/webhook/webhook.go Outdated Show resolved Hide resolved
server/webhook/jobs.go Show resolved Hide resolved
lieut-data
lieut-data requested changes Dec 22, 2022
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @spirosoik!

server/webhook/webhook.go Outdated Show resolved Hide resolved
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jan 2, 2023
@spirosoik spirosoik mentioned this pull request Jan 10, 2023
Merged
@hanzei
Copy link
Collaborator

hanzei commented Jan 12, 2023

@lieut-data I think the PR is ready for a another review from you

lieut-data
lieut-data approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @spirosoik!

@lieut-data lieut-data merged commit 4f646cf into master Jan 12, 2023
@lieut-data lieut-data deleted the fix/path-namespace-job-event-handling branch January 12, 2023 14:49
@DHaussermann
Copy link

@lieut-data or @spirosoik is there any functional testing needed here?
I'm don't quite understand the change. Can either of you provide some guidance on how to validate tis change or regression test it? Could this negatively impact subscription creation or delivery?

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@mickmister mickmister mickmister approved these changes

Assignees

@spirosoik spirosoik

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spirosoik @hanzei @DHaussermann @lieut-data @mickmister