Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious message re: pipeline info #355

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

lieut-data
Copy link
Member

Summary

See #341 (comment).

@lieut-data lieut-data added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 10, 2023
@DHaussermann DHaussermann mentioned this pull request Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 32.45% // Head: 32.46% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7ba986e) compared to base (8106e4a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   32.45%   32.46%           
=======================================
  Files          21       21           
  Lines        3389     3388    -1     
=======================================
  Hits         1100     1100           
+ Misses       2182     2181    -1     
  Partials      107      107           
Impacted Files Coverage Δ
server/command.go 24.09% <ø> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testes and passed

  • Quick functional testing to ensure the line of text has been removed
  • No other regression testing needed the feature mentioned did not yet exists
    LGTM!

Please re-request QA review if any other code changes are added

@DHaussermann DHaussermann added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Jan 10, 2023
@mickmister mickmister merged commit 0e0a0c4 into master Jan 10, 2023
@mickmister mickmister deleted the remove-spurious-pipeline-info-information branch January 10, 2023 23:15
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer QA Review Done PR has been approved by QA labels Jan 12, 2023
@hanzei hanzei added this to the v1.6.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants