Remove usage of model.AppError

[srkgupta]

Summary

Remove usage of model.AppError in Gitlab plugin

Ticket Link

https://mattermost.atlassian.net/browse/MM-50986

[codecov]

Codecov Report

Patch coverage: 11.92% and project coverage change: +0.11 🎉

Comparison is base (2b10e7c) 32.17% compared to head (c7080b6) 32.29%.

❗ Current head c7080b6 differs from pull request most recent head a87aa5a. Consider uploading reports for the commit a87aa5a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   32.17%   32.29%   +0.11%     
==========================================
  Files          21       21              
  Lines        3468     3437      -31     
==========================================
- Hits         1116     1110       -6     
+ Misses       2242     2217      -25     
  Partials      110      110              

Impacted Files	Coverage Δ
server/cluster.go	0.00% <0.00%> (ø)
server/configuration.go	35.38% <0.00%> (-1.13%)	⬇️
server/telemetry.go	0.00% <0.00%> (ø)
server/api.go	23.09% <4.76%> (+0.04%)	⬆️
server/command.go	23.56% <5.88%> (ø)
server/plugin.go	15.84% <15.55%> (+0.15%)	⬆️
server/webhook.go	40.11% <22.22%> (ø)
server/subscriptions.go	56.15% <33.33%> (+0.33%)	⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mickmister]

LGTM 👍

[m1lt0n]

Looks good! Only comment: there is an occurrence of model.AppError in command.go in the ExecuteCommand, is this possible to be updated too or not?

[srkgupta]

Looks good! Only comment: there is an occurrence of model.AppError in command.go in the ExecuteCommand, is this possible to be updated too or not?

Thanks @m1lt0n. Nice catch. I have updated the occurrence in ExecuteCommand function too.

[hanzei]

Nice work, @srkgupta 👍

I left a few comments below. The most important item is to check if the slash command still works.

[hanzei]

Nit pick:

mattermost-plugin-gitlab/server/command.go

Line 95 in c7080b6

iconData, err := command.GetIconData(p.API, "assets/icon.svg")

can be updated to iconData, err := command.GetIconData(&p.client.System, "assets/icon.svg") so p.API is used even less.

[srkgupta]

Hi @hanzei

I have made all the changes based on your feedback. Requesting your re-review on this.

Thanks

[hanzei]

LGTM 🚀

[hanzei]

@DHaussermann Heads up that this PR is ready for your review

[DHaussermann]

Tested and passed

• Setup and smoke tested GitLab
• Connect and disconnect from browser and desktop
• Various commands to retrieve data
• Created subscription and ensured deliveries are working
• RHS works to show connection and subscribe options
• Lists of work items open in RHS as expected
• No changes in behavior found
• Nothing unusual in the logs

LGTM!