[MM51547] Fix telemetry for gitlab and add account connected event #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 32.33% 32.17% -0.16%
==========================================
Files 21 21
Lines 3451 3468 +17
==========================================
Hits 1116 1116
- Misses 2225 2242 +17
Partials 110 110
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
m1lt0n
commented
Mar 28, 2023
| @@ -400,6 +400,8 @@ func (p *Plugin) completeConnectUserToGitlab(c *Context, w http.ResponseWriter, | |||
| } | |||
| } | |||
|
|
|||
| p.TrackUserEvent("account_connected", userID, nil) | |||
There was a problem hiding this comment.
@mickmister is this the most proper/accurate place or should it be within the else block with the welcome message?
There was a problem hiding this comment.
This is correct. If it's in the else block, it doesn't get tracked if the wizard is used.
spirosoik
reviewed
Mar 28, 2023
|
@spirosoik done |
spirosoik
approved these changes
Mar 28, 2023
m1lt0n
added
4: Reviews Complete
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
https://mattermost.atlassian.net/browse/MM-51547