-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase slash command timeout to 30 seconds #375
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
=======================================
Coverage 32.20% 32.20%
=======================================
Files 21 21
Lines 3465 3465
=======================================
Hits 1116 1116
Misses 2242 2242
Partials 107 107
☔ View full report in Codecov by Sentry. |
@@ -88,7 +88,7 @@ const ( | |||
) | |||
|
|||
const ( | |||
commandTimeout = 6 * time.Second | |||
commandTimeout = 30 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be this configurable instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spirosoik In general our solution has been to increase this to 30 seconds in plugin projects. I think having this as a plugin config setting is surfacing an implementation detail, but I'm not opposed to having it configurable. We would want to support configuring the http timeout as well, and be consistent on other projects and apply it there too. What do you think?
We'll defer QA, from offline discussion with @DHaussermann |
Summary
The timeout for slash commands is currently 6 seconds, which is causing issues for the
/gitlab webhook add
command. This PR increases the timeout to 30 seconds, which is what is currently used for incoming http requests:mattermost-plugin-gitlab/server/api.go
Line 31 in de004a9
Ticket Link
Fixes #374