Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-384] Fix Typo in /gitlab help output for /gitlab pipelines run #385

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

DieAkuteSense
Copy link
Contributor

@DieAkuteSense DieAkuteSense commented Jun 21, 2023

Summary

There was an error in the output text of /gitlab help, which is fixed with this PR.

Ticket Link

Fixes Issue #384

…nes run

Help should output `/gitlab pipelines run` instead of `/gitlab pipeline run`
@mattermost-build
Copy link
Contributor

Hello @DieAkuteSense,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Copy link
Member

@spirosoik spirosoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. good catch

@spirosoik
Copy link
Member

/check-cla

@spirosoik
Copy link
Member

@DieAkuteSense please check this #385 (comment)

@DieAkuteSense
Copy link
Contributor Author

/check-cla

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (842c6b3) 33.03% compared to head (5234b9d) 33.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   33.03%   33.03%           
=======================================
  Files          22       22           
  Lines        4002     4002           
=======================================
  Hits         1322     1322           
  Misses       2549     2549           
  Partials      131      131           
Impacted Files Coverage Δ
server/command.go 24.72% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei linked an issue Jun 28, 2023 that may be closed by this pull request
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jun 28, 2023
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jun 28, 2023
@hanzei hanzei added this to the v1.7.0 milestone Jun 28, 2023
@hanzei hanzei merged commit 03e6909 into mattermost:master Jun 28, 2023
11 checks passed
@DieAkuteSense DieAkuteSense deleted the patch-3 branch June 29, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in output of /gitlab help
4 participants