✨ use bot account #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
approved these changes
May 14, 2019
| @@ -3,6 +3,7 @@ | |||
| "name": "GitLab", | |||
| "description": "GitLab plugin for Mattermost.", | |||
| "version": "0.2.0", | |||
| "min_server_version": "5.10.0", | |||
There was a problem hiding this comment.
Please keep in mind that you have to bump this to 5.12 eventually.
| @@ -47,7 +48,7 @@ func (p *Plugin) getCommandResponse(responseType, text string) *model.CommandRes | |||
| ResponseType: responseType, | |||
| Text: text, | |||
| Username: GITLAB_USERNAME, | |||
| IconURL: p.getConfiguration().ProfileImageURL, | |||
| IconURL: path.Join(*p.API.GetConfig().ServiceSettings.SiteURL, "plugins", manifest.Id, "assets", "profile.png"), | |||
There was a problem hiding this comment.
You can use GetBundlePath instead.
There was a problem hiding this comment.
Nop, GetBundlePath return an absolute path e.g. /home/user/.... I want an http URL. Maybe a cool helper could be GetHTTPBundlePath!?
There was a problem hiding this comment.
What would GetHTTPBundlePath() return? ServiceSettings.SiteURL + "plugins" + pluginID?
| github.com/mattn/go-sqlite3 v1.10.0 // indirect | ||
| github.com/mitchellh/go-testing-interface v1.0.0 // indirect | ||
| github.com/mitchellh/mapstructure v1.1.2 // indirect | ||
| github.com/mattermost/mattermost-server v0.0.0-20190509204005-3f3bc5c49c37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge thanks to @crspeller for inspiration
Cc @hanzei @DHaussermann
Fix #9
Fix #6
Fix #20