Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-392: Allow system admins to provide a block of text to display in output of /jira help #419

Merged
merged 1 commit into from Jan 4, 2020
Merged

GH-392: Allow system admins to provide a block of text to display in output of /jira help #419

merged 1 commit into from Jan 4, 2020

Conversation

themaverikk
Copy link
Contributor

…with the output of command

Summary

In system console, jira admin can specify extra help-text to be shown along with the output of command /jira help.

Ticket Link

Fixes #392

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Dec 18, 2019
crspeller
crspeller approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@crspeller crspeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Bit confused about the formatting but I see it was approved on the ticket.

@levb levb added the 1: PM Review Requires review by a product manager label Dec 22, 2019
@levb levb added the 1: UX Review Requires review by a UX Designer label Dec 22, 2019
@levb levb requested review from levb and removed request for mickmister December 22, 2019 17:20
levb
levb approved these changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending UX feedback. Thank you @themaverikk, this should be a useful feature for sysadmins.

@levb levb removed the 2: Dev Review Requires review by a core committer label Dec 22, 2019
@asaadmahmood
Copy link
Contributor

@themaverikk Can we have a screenshot of this? I was away so wasn't much available to review this sooner.

asaadmahmood
asaadmahmood approved these changes Dec 25, 2019
View reviewed changes
Copy link
Contributor

@asaadmahmood asaadmahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall however, doesn't look like much frontend UI code was affected.

@themaverikk
Copy link
Contributor Author

@asaadmahmood Screenshots are already attached on GitHub ticket: #392. Would you mind having a look there?

@asaadmahmood
Copy link
Contributor

Cool, thanks.

aaronrothschild
aaronrothschild reviewed Dec 30, 2019
View reviewed changes
Copy link
Contributor

@aaronrothschild aaronrothschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for your contribution @themaverikk !

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Dec 30, 2019
DHaussermann
DHaussermann approved these changes Jan 2, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed
This was implemented exactly as described in the related issue. Tested help with and without custom text. No issues found.
Added this feature to release testing.
LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 1: UX Review Requires review by a UX Designer 3: QA Review Requires review by a QA tester labels Jan 2, 2020
@mickmister mickmister merged commit 031604c into mattermost:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronrothschild aaronrothschild aaronrothschild approved these changes

@levb levb levb approved these changes

@crspeller crspeller crspeller approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MM-18811] Allow system admins to provide a block of text to display in output of /jira help
8 participants
@themaverikk @asaadmahmood @aaronrothschild @levb @crspeller @DHaussermann @mickmister @hanzei