Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autocomplete icon #653

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Add Autocomplete icon #653

merged 1 commit into from
Sep 13, 2020

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Sep 9, 2020

Summary

Screenshot from 2020-09-08 18-12-40
Screenshot from 2020-09-08 18-12-24

Ticket Link

Fixes #652

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester 1: UX Review Requires review by a UX Designer labels Sep 9, 2020
@hanzei hanzei added this to the v3.0 milestone Sep 9, 2020
@hanzei
Copy link
Collaborator Author

hanzei commented Sep 9, 2020

@jfrerich I would love to get this into v3.0 as it's a quick but great improvment.

@codecov-commenter
Copy link

Codecov Report

Merging #653 into master will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   34.50%   34.71%   +0.21%     
==========================================
  Files          51       51              
  Lines        5684     5692       +8     
==========================================
+ Hits         1961     1976      +15     
+ Misses       3530     3524       -6     
+ Partials      193      192       -1     
Impacted Files Coverage Δ
server/command.go 19.34% <100.00%> (+0.97%) ⬆️
server/subscribe.go 68.89% <0.00%> (+0.38%) ⬆️
server/plugin.go 17.15% <0.00%> (+1.18%) ⬆️
server/instances.go 37.61% <0.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf30c36...a31d308. Read the comment docs.

Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanzei, this is awesome! Thanks!

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Icon always displays as expected
  • Checked icon looks good on all themes
  • Tested on desktop and various browsers
  • Checked browser dev tools Console and network tab - saw nothing out of the ordinary

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 12, 2020
@hanzei hanzei merged commit 10aa3b1 into master Sep 13, 2020
@hanzei hanzei deleted the command_icon branch September 13, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon to autocomplete data
6 participants