-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Autocomplete icon #653
Conversation
@jfrerich I would love to get this into |
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 34.50% 34.71% +0.21%
==========================================
Files 51 51
Lines 5684 5692 +8
==========================================
+ Hits 1961 1976 +15
+ Misses 3530 3524 -6
+ Partials 193 192 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanzei, this is awesome! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Icon always displays as expected
- Checked icon looks good on all themes
- Tested on desktop and various browsers
- Checked browser dev tools Console and network tab - saw nothing out of the ordinary
LGTM!
Summary
Ticket Link
Fixes #652