Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement autorespond feature #188

Merged
merged 27 commits into from
Aug 21, 2020
Merged

Conversation

MatthewDorner
Copy link
Collaborator

This is a duplicate of my PR which keeps getting broken since the repo was taken private and then back to public: #126. My mattermost-plugin-mscalendar repo still shows itself as being forked from cpurta/mattermost-plugin-msoffice so it's still broken, and I'm making this PR from my new fork in case you want to just merge this one or if the other breaks again.

@codecov-commenter
Copy link

Codecov Report

Merging #188 into master will decrease coverage by 0.04%.
The diff coverage is 21.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   23.52%   23.48%   -0.05%     
==========================================
  Files          62       64       +2     
  Lines        2516     2602      +86     
==========================================
+ Hits          592      611      +19     
- Misses       1850     1913      +63     
- Partials       74       78       +4     
Impacted Files Coverage Δ
server/command/auto_respond.go 0.00% <0.00%> (ø)
server/command/command.go 41.11% <0.00%> (-0.94%) ⬇️
server/command/help.go 0.00% <0.00%> (ø)
server/mscalendar/mscalendar.go 100.00% <ø> (ø)
server/mscalendar/settings.go 0.00% <0.00%> (ø)
server/mscalendar/welcome_flow.go 0.00% <0.00%> (ø)
server/mscalendar/auto_respond.go 61.29% <61.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9b8e3...714eac8. Read the comment docs.

@larkox
Copy link
Contributor

larkox commented Aug 21, 2020

Thank you very much @MatthewDorner ! I think we can safely close the other PR, and continue with this one, in case any other change is needed (I hope not!).

@larkox larkox self-requested a review August 21, 2020 18:30
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as previous PR was already approved.

@larkox
Copy link
Contributor

larkox commented Aug 21, 2020

@DHaussermann @mickmister Merging this PR since the original one was already approved by all of us, and was ready to merge.

@larkox larkox merged commit b8aff5a into mattermost:master Aug 21, 2020
@larkox larkox added the 4: Reviews Complete All reviewers have approved the pull request label Aug 21, 2020
mickmister added a commit that referenced this pull request Sep 9, 2021
mickmister added a commit that referenced this pull request Sep 9, 2021
mickmister added a commit that referenced this pull request Sep 15, 2021
* Revert "Implement autorespond feature (#188)"

This reverts commit b8aff5a.

* re-add GetMattermostUserStatus method to PluginAPI interface

* mocks

* guard against error type issue
@mickmister mickmister mentioned this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants